-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix column names in df upload v2 #974
Conversation
There are several changes, so it will need acceptance in addition to the CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests for a cumbersome problem.
I left a couple of comments and a question.
Feel free to merge this as it is.
Wait, I leave acceptance for someone else. Maybe @esloho can help with acceptance. |
Tips for acceptance:
|
OK LGTM. It seems that the upload is working 🎉 I have tested the publication too. I have some recommendations:
|
Ok cool. I am going to merge it. About the suggestions, let us discuss them in next iterations. Thanks |
fix: #922
In addition to the issue info, I am solving another problem: until now, we were filtering column names, getting the geometry and getting column names in different places (table creation, copy query, _rows, ...) As a result, we could get a different number of columns in different places. Now, we are going to use
DataframeColumnsInfo
to get all the info once at the begining.