Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Feature/colour command #125

Merged
merged 14 commits into from
Jun 22, 2019
Merged

Feature/colour command #125

merged 14 commits into from
Jun 22, 2019

Conversation

Ikinon
Copy link
Contributor

@Ikinon Ikinon commented Jun 15, 2019 •
edited
Loading

Pull request

  • I have read and agreed to the code of conduct.
  • I have read and complied with the contributing guidelines.
  • What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
  • I have tested all of my changes.

Feature

ColourCommand

@DeadlyFirex
Copy link
Contributor

Possibly make the getColor work inside an ColorUtil, would that be possible?

@binaryoverload binaryoverload mentioned this pull request Jun 16, 2019
Closed
@Ikinon
Copy link
Contributor Author

Ikinon commented Jun 16, 2019

@binaryoverload you stated a lot of this needs redoing in a voice chat, I'm going to need help on that

@binaryoverload binaryoverload added this to the Alpha milestone Jun 20, 2019
@Ikinon Ikinon marked this pull request as ready for review June 22, 2019 15:58
binaryoverload
binaryoverload reviewed Jun 22, 2019
View reviewed changes
Copy link
Member

@binaryoverload binaryoverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you've done is good, we just need to tidy up the mess from before

src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCommand.java Outdated Show resolved Hide resolved
Ikinon and others added 4 commits June 22, 2019 18:01
@Ikinon @binaryoverload
Update src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCom…
efb7bd0 
…mand.java

Co-Authored-By: William Oldham <wegg7250@gmail.com>
@Ikinon @binaryoverload
Update src/main/java/org/cascadebot/cascadebot/commands/fun/ColourCom…
092750f 
…mand.java

Co-Authored-By: William Oldham <wegg7250@gmail.com>
@Ikinon @binaryoverload
Apply suggestions from code review
3718268 
Co-Authored-By: William Oldham <wegg7250@gmail.com>
@Ikinon
Get stuff simplified
1abed0d 
and don't ever use the suggested changes it breaks
@weeryan17 weeryan17 merged commit 8010338 into CascadeBot:dev Jun 22, 2019
@Ikinon Ikinon deleted the feature/ColourCommand branch June 24, 2019 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHawkinss JamesHawkinss JamesHawkinss requested changes

@weeryan17 weeryan17 weeryan17 approved these changes

@binaryoverload binaryoverload binaryoverload approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.
5 participants
@Ikinon @DeadlyFirex @weeryan17 @binaryoverload @JamesHawkinss