Issue #41: The more I look into this issue, the more I think the func… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Castaglia
force-pushed
the
aws-sighup-issue41-adjustments
branch
from
3302561
to
cc86a02
Compare
…tionality issues stem from using the wrong internal event; let's use the postparse event. The `core.postparse` event is dispatched even after a SIGHUP/restart, whereas we were previously using `core.startup`, which only happens once at process startup. And that means that any settings/connections, closed/recycled during the SIGHUP/restart handling, might not be properly reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tionality issues stem from using the wrong internal event; let's use the postparse event.
The
core.postparseevent is dispatched even after a SIGHUP/restart, whereas we were previously usingcore.startup, which only happens once at process startup. And that means that any settings/connections, closed/recycled during the SIGHUP/restart handling, might not be properly reset.