Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body in request #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AntoineGirard
Copy link

@AntoineGirard AntoineGirard commented Aug 14, 2019

Add body request in HTTP monitor.

It could be permit to construct advanced scenarios.

Copy link

@mscalessio mscalessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this changes?

examples/
.idea

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to put this in your global .gitignore

@@ -42,7 +44,7 @@ type HTTPMonitor struct {

// TODO: test
func (monitor *HTTPMonitor) test() bool {
req, err := http.NewRequest(monitor.Method, monitor.Target, nil)
req, err := http.NewRequest(monitor.Method, monitor.Target, strings.NewReader(monitor.Body))
for k, v := range monitor.Headers {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could loop for a list of form key and value like the Headers

@rahulbhatiya-NU
Copy link

Can you please merge this PR ASAP.. I need this feature of adding a Request Body in Monitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants