C backend for Catala : the closure conversion strikes back #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denismerigoux
added
✨ enhancement
Testing with dune exec catala -- Lcalc -s S tests/test_func/good/closure_conversion.catala_en --avoid_exceptions -O --closure_conversion
denismerigoux
force-pushed
the
c_backend
branch
from
280368c
to
7702949
Compare
|
Merging this now because @adelaett depends on some of this code. |
|
@AltGr do you think you can review tomorrow to unblock Alain? |
AltGr
approved these changes
Mar 24, 2023
| if not options.avoid_exceptions then | ||
| Errors.raise_error | ||
| "Option --avoid_exceptions must be enabled for \ | ||
| --closure_conversion"; |
There was a problem hiding this comment.
Might be worth having --avoid_exceptions automatically be turned on in this case then ?
There was a problem hiding this comment.
Since --avoid_exceptions and --closure_conversion are experimental these days I want the CLI to force users to actively activate both and not have them activated silently.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #204.
Changelog