Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Rename Host to UrlBase #46

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Rename Host to UrlBase #46

merged 2 commits into from
Jul 6, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Jul 5, 2017

As per @jcjimenez's comment, renaming all host references to urlBase to avoid confusion.

No functional change.

@c-w c-w requested a review from kevinhartman July 5, 2017 17:42
@c-w c-w added the in progress label Jul 5, 2017
@c-w c-w force-pushed the host-baseurl-distinction branch from 72963d8 to 92ee58a Compare July 6, 2017 16:58
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 73c3342 into master Jul 6, 2017
@c-w c-w deleted the host-baseurl-distinction branch July 6, 2017 17:20
@c-w c-w removed the in progress label Jul 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants