i18n: Remove XML entity for docs URL #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The &folder_ignore_delete_docs_url; entity is used to avoid repeating the URL verbatim in translations strings. While this is a good approach in principle, it does come with a couple of drawbacks: 1. Automated processing via XSLT will resolve the entity refs automatically, this cannot be easily avoided. 2. It is a one-off pattern, used only for this URL. All others are part of the translation strings verbatim. If used stand-alone, they are marked translatable="false". 3. It is still error-prone to typos when making the translation. If the URL is screwed up, it won't get the user to its target. But if the entity reference is misspelled, there will be nothing to look at probably. Any possible benefits don't outweigh these and the added complexity, thus get rid of the entity references (using a simple XSLT transform).
acolomb
changed the title
|
Note that this will lead to conflicts when merging #1033 in advance. I suggest the following merge order, and will fix any upcoming conflicts ASAP (already done locally).
And as of this writing, Hosted Weblate has some troubles with losing the git remote repo connection every night, leading to alerts. I've contacted their support about it, trying not to touch anything in the meantime so they can troubleshoot. |
|
Weblate issue should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
&folder_ignore_delete_docs_url;entity is used to avoid repeating the URL verbatim in translations strings. While this is a good approach in principle, it does come with a couple of drawbacks:Automated processing via XSLT (such as i18n: Indirect string-array declarations through arrays.xml #1051) will resolve the entity refs automatically, this cannot be easily avoided.
It is a one-off pattern, used only for this URL. All others are part of the translation strings verbatim. If used stand-alone, they are marked
translatable="false".It is still error-prone to typos when making the translation. If the URL is screwed up, it won't get the user to its target. But if the entity reference is misspelled, there will be nothing to look at probably.
Any possible benefits don't outweigh these and the added complexity, thus get rid of the entity references (using a simple XSLT transform).