Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency on long-press #706

Closed
TheLastProject opened this issue Jan 1, 2022 · 11 comments · Fixed by #943
Closed

Transparency on long-press #706

TheLastProject opened this issue Jan 1, 2022 · 11 comments · Fixed by #943
Assignees
Labels
common: frequent Affects or can be seen by most users regularly or impacts most users' first experience good first issue Good for newcomers severity: tolerable Low/no impact on users type: enhancement New feature or request

Comments

@TheLastProject
Copy link
Member

Currently, long-pressing a card to select makes the background fully black or white. This makes it harder to recognise the card without having to read the text. It would be good if we could have some transparency again.

So this is what we don't want:
photo_2022-01-01_22-52-19

@TheLastProject TheLastProject added type: enhancement New feature or request good first issue Good for newcomers labels Jan 1, 2022
@TheLastProject TheLastProject added common: frequent Affects or can be seen by most users regularly or impacts most users' first experience severity: tolerable Low/no impact on users labels Feb 5, 2022
@samarthasthan
Copy link
Contributor

Hey @TheLastProject can i work on this?

@TheLastProject
Copy link
Member Author

Sure, go for it! :)

@samarthasthan
Copy link
Contributor

@TheLastProject was this what you were talking about? the tick that is coming?

Screen.Recording.2022-07-21.at.11.05.14.AM.mp4

@TheLastProject
Copy link
Member Author

TheLastProject commented Jul 21, 2022

Specifically the background. The green becomes fully black. It would be good if it just became a darker green or something, so you can still easily see it was the green card you selected.

(Well, in your example it is green, it could be any colour or even an image)

@samarthasthan
Copy link
Contributor

@TheLastProject Look I have done it, you confirm whether it looks right or may I change something in it?

Screen.Recording.2022-07-21.at.8.42.56.PM.mp4

@TheLastProject
Copy link
Member Author

The colour looks a bit weird but yeah, that's basically it. Does it also work for images? You can set an image for a card by clicking the coloured letter.

@samarthasthan
Copy link
Contributor

@TheLastProject Select which one looks good and also now working on image

Spring Floral Collage Wallpaper (1)

@TheLastProject
Copy link
Member Author

TheLastProject commented Jul 21, 2022

I think black (number 2) looks best, because it keeps the original image closest to the original but the checkmark is still readable :)

@samarthasthan
Copy link
Contributor

I think black (number 2) looks best, because it keeps the original image closest to the original but the checkmark is still readable :)

so should i remove this white tick mark or let it be?

@TheLastProject
Copy link
Member Author

Keeping it white looks best I think

@samarthasthan
Copy link
Contributor

@TheLastProject ok let me I finalize it and theni will put a pull request

@TheLastProject TheLastProject linked a pull request Jul 21, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: frequent Affects or can be seen by most users regularly or impacts most users' first experience good first issue Good for newcomers severity: tolerable Low/no impact on users type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants