Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-439 Re-Implement the drawing surface and basic drawing in Flutter #1

Merged
merged 14 commits into from
Jun 24, 2022
Merged

PAINTROID-439 Re-Implement the drawing surface and basic drawing in Flutter #1

merged 14 commits into from
Jun 24, 2022

Conversation

krispykalsi
Copy link
Collaborator

  • A simple drawing brush and surface
  • Top and bottom app bars with Material 3 style

First PR! Leaving my mark here :D Excited to see this app grow

@krispykalsi
initial commit
ff7893f
@krispykalsi
implement drawing board
b8aec09
@krispykalsi
restructure + cleanup code
911c761 
- add tool, command, command manager
@krispykalsi
- add tests (tool, command)
eac1b22 
- add const (wherever possible)
@krispykalsi
modify readme (copy from parent repo)
9594601
@krispykalsi
fix brush tool test
598916c 
compare in relative values instead of absolute
@krispykalsi
add required instructions for getting started in readme
5dd9ffd
@krispykalsi
add app icon and change app display name
a3d86a3
@krispykalsi
refactor + more tests
da6b58a 
- add more robust brush tool tests
- rename DrawCommand -> GraphicCommand
- make factories graphic, command factories
- add test coverage, generated mocks to gitignore
juliajulie95
juliajulie95 reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I added some suggestions, please have a look

README.md Outdated Show resolved Hide resolved
android/app/build.gradle Outdated Show resolved Hide resolved
android/app/src/main/res/drawable-v21/launch_background.xml Outdated Show resolved Hide resolved
android/app/src/main/res/drawable/launch_background.xml Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
lib/tool/brush_tool.dart Outdated Show resolved Hide resolved
lib/ui/pocket_paint.dart Show resolved Hide resolved
lib/ui/drawing_board.dart Show resolved Hide resolved
juliajulie95
juliajulie95 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@juliajulie95 juliajulie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you! :)

@ThorstenBandel ThorstenBandel merged commit 95cfe43 into Catrobat:develop Jun 24, 2022
@krispykalsi krispykalsi deleted the PAINTROID-439 branch June 24, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliajulie95 juliajulie95 juliajulie95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krispykalsi @juliajulie95 @ThorstenBandel