fix: card title margin #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2022 21:30
|
・アカウント詳細ページ
レビューお願いいたします。 |
taro04
requested review from
YasunoriMATSUOKA,
Senna46 and
kimurayu45z
and removed request for
Senna46 and
YasunoriMATSUOKA
YasunoriMATSUOKA
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
@taro04
コードレビューのみですが、実装OKと思います。
Fractionの箇所は、1%的な比率を表しているのかなとも思いましたが、一旦このまま進めてもらってかまいません。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/CauchyE/telescope/issues/220
の修正です。
mat-cardとタイトルの上下の余白を調整しました。
・基本はカード間は1rem （カードの内容によっては調整）
・カードとタイトル間は０
・カードタイトルのサイズをh3からh2へ統一。
デバック途中の箇所あるので、
次回確認後、レビューをお願いさせていただきます。