Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHGNet.version property #86

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Add CHGNet.version property #86

merged 8 commits into from
Oct 23, 2023

Conversation

janosh
Copy link
Collaborator

@janosh janosh commented Oct 23, 2023

d0ee30f add CHGNet @property version
1747180 refactor CHGNet.load() and pass model_name as version to CHGNet.__init__()
7c22ab1 add test_model_load()

@janosh janosh added testing Test all the things ux User experience labels Oct 23, 2023
@janosh janosh enabled auto-merge (squash) October 23, 2023 03:02
@janosh janosh temporarily deployed to github-pages October 23, 2023 03:06 — with GitHub Actions Inactive
@BowenD-UCB
Copy link
Collaborator

this is so quick! thanks for the fix

@janosh
Copy link
Collaborator Author

janosh commented Oct 23, 2023

This isn't really a fix, just a QoL improvement. I didn't look at #85 yet if that's what you're thinking.

@janosh janosh temporarily deployed to github-pages October 23, 2023 03:11 — with GitHub Actions Inactive
@janosh janosh temporarily deployed to github-pages October 23, 2023 03:27 — with GitHub Actions Inactive
@janosh janosh temporarily deployed to github-pages October 23, 2023 03:35 — with GitHub Actions Inactive
auto-merge was automatically disabled October 23, 2023 03:43

Head branch was modified

@BowenD-UCB BowenD-UCB temporarily deployed to github-pages October 23, 2023 03:47 — with GitHub Actions Inactive
@janosh
Copy link
Collaborator Author

janosh commented Oct 23, 2023

The pretrained checkpoint files are not included in the v0.3.0 PyPI release.
This was fixed in 0f02786 in this PR and we'll be making a v0.3.1 hot fix release today.

@janosh janosh merged commit 74a6a70 into main Oct 23, 2023
10 checks passed
@janosh janosh deleted the model-version-prop branch October 23, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing Test all the things ux User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janosh @BowenD-UCB