-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase star render distance #503
Increase star render distance #503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested it with larger stardb.dat? For example with one from Celestia Origin?
I haven't tested it at all, since I don't have a C++ compiler and there weren't any artifacts generated. |
The more distant objects use have the deeper levels of octree present, i.e. more time required to traverse it. |
Okay. Janus recompiled Celestia with the same one line change and had no problems (see the first link). You can check for yourself if you want. If there are really problems I can reduce the limit to 100 million light-years; this is still enough for M87*. |
He didn't tested it with larger stars.db. I will test it the other day. |
Maybe in the long run, you can probably test for around 100 GLY star render limit. Janus also made a commit regarding that but I forgot which number |
It would be easy enough to increase the limit to 100 Gly - just add two more zeroes. However, I don't see the point, since this is larger than the observable universe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, i don't see performance drops with CO star db comparing to the default db
Based on this thread and this one, I've increased the maximum star render distance to 1 billion light-years. Now Celestia should be able to render M87*, and other such distant objects.