Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase star render distance #503

Merged

Conversation

SevenSpheres
Copy link
Contributor

Based on this thread and this one, I've increased the maximum star render distance to 1 billion light-years. Now Celestia should be able to render M87*, and other such distant objects.

Copy link
Member

@375gnu 375gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested it with larger stardb.dat? For example with one from Celestia Origin?

@SevenSpheres
Copy link
Contributor Author

SevenSpheres commented Nov 11, 2019

I haven't tested it at all, since I don't have a C++ compiler and there weren't any artifacts generated.
I don't see why simply increasing the render limit would cause problems.

@375gnu
Copy link
Member

375gnu commented Nov 11, 2019

The more distant objects use have the deeper levels of octree present, i.e. more time required to traverse it.

@SevenSpheres
Copy link
Contributor Author

Okay. Janus recompiled Celestia with the same one line change and had no problems (see the first link). You can check for yourself if you want. If there are really problems I can reduce the limit to 100 million light-years; this is still enough for M87*.

@375gnu
Copy link
Member

375gnu commented Nov 12, 2019

He didn't tested it with larger stars.db. I will test it the other day.

@LafuenteAstronomy
Copy link

LafuenteAstronomy commented Nov 12, 2019

Maybe in the long run, you can probably test for around 100 GLY star render limit. Janus also made a commit regarding that but I forgot which number

@SevenSpheres
Copy link
Contributor Author

Maybe in the long run, you can probably test for around 100 GLY star render limit.

It would be easy enough to increase the limit to 100 Gly - just add two more zeroes. However, I don't see the point, since this is larger than the observable universe.

Copy link
Member

@375gnu 375gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i don't see performance drops with CO star db comparing to the default db

@levinli303 levinli303 merged commit 32ce75e into CelestiaProject:master Nov 21, 2019
@SevenSpheres SevenSpheres deleted the increase-star-render-distance branch November 21, 2019 01:35
@SevenSpheres SevenSpheres mentioned this pull request Nov 26, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants