-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev renpycompat #192
Dev renpycompat #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"codegen" should indeed be removed. But magic
and translate
are still submodules of decompiler
so those ought to stay.
OK. I misunderstood the role of the exports in init somehow. I added renpycompat. Is this correct? |
Good one, yep that is correct. I just spotted this btw: the correct one is typing.BinaryIO for this, which covers both. so from typing import BinaryIO
def random_func(outfile: BinaryIO):
pass |
Anyway, looks good, if you don't mind can you squash it into a single commit? I can also do that at merge time but then it messes with the commit authorship I think. |
- moved defintion of renpy fake module from "__init__" - defined shorthands to magic module - corrected related imports - adjusted "__all__" exports
I did and something happened in Codium and the sync did error so i needed to do a reset. Should be OK now, i checked again but better look also. Got the strange feel i forgot something. But what. 😖 |
Looked fine to me so I merged it, and I also propagated support for it in un.rpyc on |
Separation of specials into own module