Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev renpycompat #192

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

madeddy
Copy link
Contributor

@madeddy madeddy commented Feb 29, 2024

Separation of specials into own module

Copy link
Owner

@CensoredUsername CensoredUsername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"codegen" should indeed be removed. But magic and translate are still submodules of decompiler so those ought to stay.

@madeddy
Copy link
Contributor Author

madeddy commented Mar 1, 2024

magic and translate are still submodules

OK. I misunderstood the role of the exports in init somehow. I added renpycompat. Is this correct?

@CensoredUsername
Copy link
Owner

CensoredUsername commented Mar 1, 2024

I added renpycompat. Is this correct?

Good one, yep that is correct.

I just spotted this btw:
# if type hints: which one would be output file? bytesIO or bytes?

the correct one is typing.BinaryIO for this, which covers both.

so

from typing import BinaryIO

def random_func(outfile: BinaryIO):
    pass

@CensoredUsername
Copy link
Owner

Anyway, looks good, if you don't mind can you squash it into a single commit? I can also do that at merge time but then it messes with the commit authorship I think.

- moved defintion of renpy fake module from "__init__"
- defined shorthands to magic module
- corrected related imports
- adjusted "__all__" exports
@madeddy
Copy link
Contributor Author

madeddy commented Mar 1, 2024

...can you squash it into a single commit

I did and something happened in Codium and the sync did error so i needed to do a reset. Should be OK now, i checked again but better look also.

Got the strange feel i forgot something. But what. 😖

@CensoredUsername CensoredUsername merged commit cd30b07 into CensoredUsername:dev Mar 2, 2024
1 check passed
@CensoredUsername
Copy link
Owner

Looked fine to me so I merged it, and I also propagated support for it in un.rpyc on dev.

@madeddy madeddy deleted the dev_renpycompat branch March 2, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants