Ensure we account for device names with suffixes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelshin
requested review from
anurlybayev,
elmarsto,
jimgao1 and
ssaini4
ssaini4
approved these changes
Dec 14, 2022
|
Might not work since we have A40/A4000. |
|
I would instead split by more types of tokens (space, dash, underscore) and also still use exact match. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed after running the ML Tools test, the source device was T4 even if it was actually P100 or V100. This bug occurred because the device names had additional suffixes (e.g. P100 had the name Tesla P100-PCIE-16GB).
Originally Skyline split the string on whitespaces and checked if the name is an exact match with any of those split strings. Now it will check if the name is a substring of the split strings.
I wish there was a better solution for this because this still seems fragile.