Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure virtual network #1296

Merged
merged 6 commits into from
Sep 5, 2019

Conversation

JunqiZhang0
Copy link
Contributor

Added virtual network creation and destruction

@adl-bot
Copy link

adl-bot commented Aug 22, 2019

Can one of the admins verify this patch?

docs/source/azure.rst Outdated Show resolved Hide resolved
@adl-bot
Copy link

adl-bot commented Sep 3, 2019

@abraverm
Copy link
Contributor

abraverm commented Sep 4, 2019

squash please

@adl-bot
Copy link

adl-bot commented Sep 4, 2019

@adl-bot
Copy link

adl-bot commented Sep 4, 2019

@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@CentOS-PaaS-SIG CentOS-PaaS-SIG deleted a comment from adl-bot Sep 4, 2019
@abraverm
Copy link
Contributor

abraverm commented Sep 5, 2019

@JunqiZhang0 - conflicts

Copy link
Contributor

@samvarankashyap samvarankashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samvarankashyap
Copy link
Contributor

samvarankashyap commented Sep 5, 2019

@JunqiZhang0 Please resolve conflicts before you merge.
Since its a minor change, I am approving it.

@adl-bot
Copy link

adl-bot commented Sep 5, 2019

@adl-bot
Copy link

adl-bot commented Sep 5, 2019

@JunqiZhang0
Copy link
Contributor Author

[merge]

@adl-bot adl-bot merged commit b6c7ab5 into CentOS-PaaS-SIG:develop Sep 5, 2019
@abraverm abraverm added the azure label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants