Avoid unnecessary creation of directories when not using cloud_config #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samvarankashyap
force-pushed
the
fix_libvirt_cirros_provisioning
branch
from
ec1a0e8
to
e5a6a3f
Compare
14rcole
approved these changes
Jan 24, 2020
samvarankashyap
force-pushed
the
fix_libvirt_cirros_provisioning
branch
from
e5a6a3f
to
a9ee6ab
Compare
|
@14rcole More updates
|
|
@samvarankashyap how about libvirt_new? Also, can you re-enable the libvirt tests or were there other reasons why they were disabled? |
|
@14rcole I have not tried libvirt_new yet. |
14rcole
approved these changes
Jan 24, 2020
|
@14rcole Am merging this PR since it fixes the general provisioning of libvirt instances without cloud-init. I will be creating another issue fixing the provisioning with cloud-init. |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary creation of directories when cloud_config is not de…clared
Further, this PR looks into the problem of provisioning instances without cloud_config.
Bug description:
when provisioning a libvirt-cirros workspace
linchpin hangs up
Steps to reproduce:
Actual behavior:
expected:
linchpin provisions cirros image.