Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirements.txt: shade #72

Merged
merged 6 commits into from
Oct 10, 2016
Merged

Update requirements.txt: shade #72

merged 6 commits into from
Oct 10, 2016

Conversation

samvarankashyap
Copy link
Contributor

No description provided.

@samvarankashyap
Copy link
Contributor Author

@herlo : updated requirements.txt with shade dependency

@samvarankashyap samvarankashyap mentioned this pull request Oct 5, 2016
Closed
herlo
herlo approved these changes Oct 6, 2016
View reviewed changes
Copy link
Contributor

@herlo herlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to include all of the requirements into a requirements.txt like this. For now, it's acceptable, but we should come up with a better approach.

herlo
herlo approved these changes Oct 6, 2016
View reviewed changes
Copy link
Contributor

@herlo herlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Good work!

@samvarankashyap samvarankashyap merged commit a4b1456 into CentOS-PaaS-SIG:master Oct 10, 2016
@samvarankashyap samvarankashyap mentioned this pull request Oct 27, 2016
Closed
@adl-bot adl-bot mentioned this pull request May 4, 2018
Merged
@adl-bot adl-bot mentioned this pull request Jul 27, 2018
Merged
@adl-bot adl-bot mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herlo herlo herlo approved these changes

Assignees

@herlo herlo

@samvarankashyap samvarankashyap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samvarankashyap @herlo