add pod and node annotation for gpu usage info #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hxhp
approved these changes
Feb 15, 2022
| @@ -0,0 +1,9 @@ | |||
| FROM debian:stretch-slim | |||
There was a problem hiding this comment.
we can create the build directory in the Makefile and put the Dockerfile in upper level directory?
| @@ -0,0 +1,2 @@ | |||
| sudo docker build -f Dockerfile -t centaurusinfra/alnair-device-plugin:ann . | |||
There was a problem hiding this comment.
add the user to the docker group instead of using sudo? also the tag needs to be consistent with our release?
Not sure this script is needed for now.
| @@ -0,0 +1,3 @@ | |||
| .PHONY: build | |||
| build: | |||
| go build -o build/bin/alnair-device-plugin cmd/alnair-device-plugin/main.go | |||
Comment on lines
+45
to
+47
| // if err != nil { | ||
| // config, err = clientcmd.BuildConfigFromFlags("", "/etc/kubernetes/scheduler.conf") //use the default path for now, pass through arg later | ||
| // } |
|
Address the above issues with a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.