[ENG-4418] No BsAlert #1861
Merged
[ENG-4418] No BsAlert #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
approved these changes
May 11, 2023
| @@ -67,6 +67,6 @@ export default class TosConsentBanner extends Component { | |||
| this.analytics.click('button', 'ToS Consent Banner - dismiss'); | |||
| this.set('didValidate', false); | |||
| this.currentUser.set('showTosConsentBanner', false); | |||
| return false; | |||
| return true; | |||
There was a problem hiding this comment.
Why do we need a return value here in the first place?
There was a problem hiding this comment.
It is used by the dismiss action in the component.
futa-ikeda
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove usage of the BsAlert from ember osf web.
Summary of Changes
Screenshot(s)
Before
After
Side Effects
@visible={{true}}or similar to the Alert component to get it to show.QA Notes
Check to make sure that the various alert banners work.