Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-5172] User settings addons tests #2240

Merged
merged 4 commits into from
Jun 18, 2024
Merged

[ENG-5172] User settings addons tests #2240

merged 4 commits into from
Jun 18, 2024

Conversation

brianjgeiger
Copy link
Contributor

@brianjgeiger brianjgeiger commented Jun 17, 2024 •
edited by jira bot
Loading

  • Ticket: ENG-5172
  • Feature flag: gravy_waffle

Purpose

Test the user settings addons page.

Summary of Changes

  1. Add tests
  2. Add test selectors
  3. Fix problem with accountOwner

@brianjgeiger brianjgeiger marked this pull request as draft June 17, 2024 13:55
@brianjgeiger brianjgeiger marked this pull request as ready for review June 17, 2024 20:44
@brianjgeiger brianjgeiger changed the title [WIP] User settings addons tests [ENG-5172] User settings addons tests Jun 17, 2024
futa-ikeda
futa-ikeda approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@futa-ikeda futa-ikeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bob Username needs a password manager 🤦

@brianjgeiger
Copy link
Contributor Author

He goes by Robert now.

@brianjgeiger brianjgeiger merged commit 578ee94 into CenterForOpenScience:feature/addon-services Jun 18, 2024
9 checks passed
@brianjgeiger brianjgeiger deleted the addons/user-settings-acceptance-tests branch June 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@futa-ikeda futa-ikeda futa-ikeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianjgeiger @futa-ikeda