Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EOSF-925] Remove file upload message if not owner of files #39

Conversation

baylee-d
Copy link

Purpose

To remove the Files uploaded here are publicly accessible and easy to share with others using the share link. message if the user is not the owner of the quickfiles.

Summary of Changes

Add conditional to check if the user is the owner of the files to determine whether or not to show the message.

Ticket

https://openscience.atlassian.net/browse/EOSF-925

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md (don't have initial release yet)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 5.469% when pulling 502e018 on baylee-d:feature/remove-publicly-accessible-message into b7e2c77 on CenterForOpenScience:develop.

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflict

@baylee-d baylee-d force-pushed the feature/remove-publicly-accessible-message branch from 502e018 to 64556fc Compare November 30, 2017 18:15
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 5.303% when pulling 64556fc on baylee-d:feature/remove-publicly-accessible-message into 51ad53f on CenterForOpenScience:develop.

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@jamescdavis jamescdavis merged commit c070913 into CenterForOpenScience:develop Nov 30, 2017
@baylee-d baylee-d deleted the feature/remove-publicly-accessible-message branch January 17, 2018 15:59
@jamescdavis jamescdavis added this to the 0.1.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants