[ENG-5519] 401 instead of CAS redirect #10592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
added a commit
that referenced
this pull request
Apr 17, 2024
This branch contains rebased & cherry-picked fixes from seven different PRs / tickets. [ENG-5480] - replace webtest plus with FlaskClient Closes #10583 commits 1e63cda..e3443f1 [ENG-5530] - fix sendgrid failures Closes #10585 commit f9ba569 [ENG-5517] - fix url encoding test issues Closes #10589 commits fd06b14..cc051c9 [ENG-5520] - fix JsonSchema issues Closes #10590 commits 1b2b084..ec51327 [ENG-5523] - Fix embargo termination failures Closes #10593 commit 41e685c [ENG-5490] - Fix github mock data Closes #10586 commits 7db5e0f..1b652d5 [ENG-5519] - 401 instead of CAS redirect Closes #10592 commits 30a3623..736ad49
|
Merged and closed by d9b757b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added to_header function (Auth class): Fixes ticket ENG-5519 by enabling retrieval of user.username.
Fixed URL decoding error: Used parse.unquote to address decoding issues.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5519