[ENG-5546] Catch all github-related errros in addons test CI suite #10606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felliott
requested changes
May 6, 2024
addons/gitlab/tests/test_views.py
Outdated
| @@ -518,24 +519,94 @@ def test_link_repo_non_existent(self, mock_repo): | |||
|
|
|||
| assert res.status_code == 400 | |||
|
|
|||
| user = 'octo-cat' | |||
There was a problem hiding this comment.
nitpick: if this is constant fixture data, can you capitalize the variable names and move it either to the top of the class definition or the file definition (whichever is more appropriate)?
addons/gitlab/tests/test_views.py
Outdated
| 'tree': {'url': 'https://docs.github.com/en/rest/git/trees', | ||
| 'sha': 'e22d92d5d90bb8f9695e9a5e2e2311a5c1997230'}, | ||
| } | ||
| repo_parents = [ |
addons/github/tests/test_views.py
Outdated
| 'tree': {'url': 'https://docs.github.com/en/rest/git/trees', | ||
| 'sha': 'e22d92d5d90bb8f9695e9a5e2e2311a5c1997230'}, | ||
| } | ||
| repo_parents = [ |
There was a problem hiding this comment.
same comment as below (sorry they are out of order)
felliott
merged commit f0c3ef6
into
CenterForOpenScience:feature/python-upgrade
1 of 6 checks passed
|
Nice! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Address 9 failed tests due to lack of mock data and missing session.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5546