[ENG-5140] #2 Update get_auth for GV and readability #10613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwalz
reviewed
May 10, 2024
addons/base/views.py
Outdated
| @@ -697,22 +697,23 @@ def osfstoragefile_update_view_analytics(self, auth, fileversion): | |||
|
|
|||
| @file_signals.file_viewed.connect | |||
| def osfstoragefile_viewed_update_metrics(self, auth, fileversion): | |||
| resource = BaseFileNode.objects.get(versions__id=fileversion.id).target | |||
| file = BaseFileNode.objects.get(versions__id=fileversion.id) | |||
There was a problem hiding this comment.
still a problem with get possibly returning multiple results
mfraezz
reviewed
May 10, 2024
addons/base/views.py
Outdated
| @@ -697,22 +697,23 @@ def osfstoragefile_update_view_analytics(self, auth, fileversion): | |||
|
|
|||
| @file_signals.file_viewed.connect | |||
| def osfstoragefile_viewed_update_metrics(self, auth, fileversion): | |||
| resource = BaseFileNode.objects.get(versions__id=fileversion.id).target | |||
| file = BaseFileNode.objects.filter(versions__id=fileversion.id).last() | |||
There was a problem hiding this comment.
.last is guaranteed to not throw a MultipleObjectsReturned error, but isn't guaranteed to deliver the correct FileNode object. Would it be possible to include it in the file_signals.file_viewed.send call instead?
There was a problem hiding this comment.
Won't all the versions have the same BaseFIleNode though? I only retrieve the version, not the full node.
There was a problem hiding this comment.
FileVersions help dedupe information, so one FileVersion can belong to many BaseFileNodes
mfraezz
reviewed
May 10, 2024
Co-authored-by: Jon Walz <jon@cos.io>
Co-authored-by: Jon Walz <jon@cos.io>
Johnetordoff
pushed a commit
to Johnetordoff/osf.io
that referenced
this pull request
May 13, 2024
into gv-files-provider-waffle * 'develop' of https://github.com/CenterForOpenScience/osf.io: [ENG-5140] #2 Update get_auth for GV and readability (CenterForOpenScience#10613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix some signals code that wasn't covered by tests.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket