[ENG-5588] - Fix test_old_password_invalid_attempts_reset_if_password_successfully_reset #10615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added follow_redirects=True as it helped return status code 200 instead of 301;
cslzchen
force-pushed
the
feature/ENG-5589
branch
from
dc6eb11
to
1d42a5a
Compare
|
Update: there was some merge conflicts so I cherry-picked the one commit, I will wait until CI is done before merging |
cslzchen
merged commit 4c56131
into
CenterForOpenScience:feature/python-upgrade
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix test_old_password_invalid_attempts_reset_if_password_successfully_reset;
Changes
200instead of301;QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5588