Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.2 #10620

Merged

Conversation

opaduchak
Copy link
Contributor

@opaduchak opaduchak commented May 20, 2024

Purpose

Upgrade OSF to Django 4.2

Changes

Bumped Django to latest patch version of 4.2, fixed all trivial errors which appeared (changed import locations, and missing attributes, etc)

QA Notes

Please make verification statements inspired by your code and what your code touches.

  • Verify
  • Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-5550

@cslzchen cslzchen self-requested a review May 21, 2024 14:09
@cslzchen cslzchen changed the title [ENG-5550] Phase 4: Initial attempt to upgrade to Django 4 [ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.12 May 22, 2024
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass done and looks great overall 🎆. I left a few comments/questions.

tests/test_preprints.py Show resolved Hide resolved
tests/test_citations.py Show resolved Hide resolved
framework/sentry/__init__.py Show resolved Hide resolved
framework/csrf/handlers.py Show resolved Hide resolved
osf_tests/test_node.py Show resolved Hide resolved
osf/models/user.py Show resolved Hide resolved
@opaduchak opaduchak changed the title [ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.12 [ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.2 May 23, 2024
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cslzchen cslzchen merged commit 7f7799f into CenterForOpenScience:feature/python-upgrade May 23, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants