-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.2 #10620
Merged
cslzchen
merged 15 commits into
CenterForOpenScience:feature/python-upgrade
from
opaduchak:ENG-5550
May 23, 2024
Merged
[ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.2 #10620
cslzchen
merged 15 commits into
CenterForOpenScience:feature/python-upgrade
from
opaduchak:ENG-5550
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
changed the title
[ENG-5550] Phase 4: Initial attempt to upgrade to Django 4
[ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.12
May 22, 2024
cslzchen
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass done and looks great overall 🎆. I left a few comments/questions.
This was referenced May 23, 2024
opaduchak
changed the title
[ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.12
[ENG-5550] Phase 4: Initial attempt to upgrade from Django 3.2 to 4.2
May 23, 2024
cslzchen
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
cslzchen
merged commit May 23, 2024
7f7799f
into
CenterForOpenScience:feature/python-upgrade
3 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade OSF to Django 4.2
Changes
Bumped Django to latest patch version of 4.2, fixed all trivial errors which appeared (changed import locations, and missing attributes, etc)
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5550