[feature] Close ERPC [OSF-7843] #7189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyrollins
force-pushed
the
feature/close-erpc
branch
3 times, most recently
from
873532a
to
a59b547
Compare
- Add active field to MetaSchema model and serializer. - Prevent disabled draft registrations from being created via APIv1 and APIv2. - Set active=False on inactive metaschemas. - Remove ACTIVE_META_SCHEMAS. - Use update_or_create() in ensure_schemas()
caseyrollins
force-pushed
the
feature/close-erpc
branch
from
a59b547
to
70977cf
Compare
caseyrollins
force-pushed
the
feature/close-erpc
branch
3 times, most recently
from
41ea0a7
to
9470551
Compare
caseyrollins
changed the title
- Return active and latest metaschemas from list endpoint. - Update metaschemas tests.
caseyrollins
force-pushed
the
feature/close-erpc
branch
from
9470551
to
9ba337e
Compare
brianjgeiger
approved these changes
Jun 1, 2017
|
Oof. This didn't fare well in the Merge Conflict wars of '17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
enabledboolean field toMetaSchemamodel and serializer.ensure_schemas()to use Django'supdate_or_create().Side Effects / Notes
/v2/metaschemas/endpoint will return only active metaschemas that are of the latest version./v2/metaschemas/<schema_id>/endpoint will return any metaschema, including previous versions and inactive schemas.QA Notes
/v2/metaschemas//v2/metaschemas/<erpc_schema_id>/)Ticket