[IN-294] Django-storages assets for providers #8371
Conversation
api/base/settings/defaults.py
Outdated
|
|
||
| DEFAULT_FILE_STORAGE = 'storages.backends.gcloud.GoogleCloudStorage' | ||
| GS_BUCKET_NAME = os.environ.get('GS_BUCKET_NAME', 'cos-osf-stage-osf-cdn') | ||
| # GOOGLE_APPLICATION_CREDENTIALS env var must be set |
There was a problem hiding this comment.
Discussed over zoom. Local dev might be interesting or require everyone to hook up staging key, some details written in the PR description might be nice.
|
|
||
| class ProviderAssetFile(BaseModel): | ||
| name = models.CharField(max_length=63) | ||
| file = models.FileField(upload_to='assets') |
There was a problem hiding this comment.
Stupid minor; I personally don't like file as a name since it technically is a builtin... but we use it all over the place so whatev (https://docs.python.org/2/library/functions.html#file)
There was a problem hiding this comment.
I had the same mixed feeling about it, but I think it's only bad practice when assigning locals to builtins, as local assignment will override them but attrs/fields/methods will not. Some examples (in addition to yours) would be that any TypedModel has a type field, or that Queryset objects have filter and all methods.
¯\_(ツ)_/¯
| {% block content %} | ||
| <div class="row"> | ||
| <div class="col-md-12"> | ||
| {% if perms.osf.delete_asset_file %} |
There was a problem hiding this comment.
might be an extra space after {%
|
|
||
| {% load static %} | ||
| {% block top_includes %} | ||
| <link rel="stylesheet" type="text/css" href="/static/css/institutions.css" /> |
mfraezz
force-pushed
the
feature/django-storage-assets
branch
from
29bcd78
to
6f0ff31
Compare
mfraezz
force-pushed
the
feature/django-storage-assets
branch
2 times, most recently
from
1542109
to
ee3a50b
Compare
mfraezz
force-pushed
the
feature/django-storage-assets
branch
from
ee3a50b
to
5c6b08b
Compare
Purpose
Implement something better than dog-food'd files committed to a git repo for branded assets.
Changes
django-storagesused for uploading static files to Google Cloud StorageAPI endpoints for assetsRelationship added to providers in the the API (so ember can reference and fetch these by name)(These two to be done in [IN-302])
QA Notes
These assets won't be visible in the ember UI until collections goes out, but test that the admin module can be used to create/edit/delete them.
Side Effects
None expected
Deployment Notes
A
GOOGLE_APPLICATION_CREDENTIALSenvironment variable must be set. See lookit's helm chart for referenceTicket
[IN-294]