Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow '=' within the body of --tla-code #122

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

expelledboy
Copy link
Contributor

Purpose

Allow base64 encoded values, and large JSON strings that include "=" characters in the body

I had no idea how to test this, so I built it and ran it within the scope of my work

image

First piece of Rust code I've ever written :)

Thank you for this project! 🫶

@JarvisCraft JarvisCraft added the enhancement New feature or request label Jun 19, 2023
@JarvisCraft JarvisCraft added this to the v0.5.0 milestone Jun 19, 2023
@JarvisCraft
Copy link
Collaborator

Congratulations on joining the rustaceans club and thanks for your PR!

I suggest that you try adding a unit-test to ensure that this behavior is correct (and does not break with future changes). You can look into rust book to see basic tutorial on writing unit tests in Rust. Alternatively, you could make a doc test by writing a doc-comment with a code example in it which would also be run by Cargo.

Copy link
Owner

@CertainLach CertainLach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CertainLach CertainLach merged commit e98be8b into CertainLach:master Jul 13, 2023
@expelledboy expelledboy mentioned this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants