Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/data model #1

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Feature/data model #1

merged 8 commits into from
Sep 22, 2023

Conversation

CesarHerr
Copy link
Owner

Hi there ✋ In this pull request I follow the following requirements:

  • Create a new app. Give it a meaningful name.
  • Initialize your project with Git.
  • Make sure that your project has Postgres database set up.
  • Build your project schema.
  • Create and run the necessary migration files.
  • Table and column names should match the ERD diagram.
  • note: photo for users table should be a link to an image
  • Foreign keys should be included.
  • Pay attention that in posts table the column holding the foreign key to the users table should be named author_id
  • All columns that are foreign keys should have a corresponding index.
  • Please be sure to take a look at the from the sneak peek if you have any questions about table or column names or data relationships.

Thank you for taking the time to review this PR ⭐!


@CesarHerr CesarHerr added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 22, 2023
@CesarHerr CesarHerr self-assigned this Sep 22, 2023
Copy link

@Reem-lab Reem-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CesarHerr , 👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Followed Gitflow 💯
  • Descriptive PR⭐
  • Kudos for working on the schema🤩
  • No Linters error ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@CesarHerr CesarHerr merged commit c369e35 into dev Sep 22, 2023
3 checks passed
@CesarHerr CesarHerr deleted the feature/dataModel branch September 22, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants