Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up 3d-tiles-tools project and dependencies #70

Merged
merged 3 commits into from
Apr 14, 2017
Merged

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Apr 14, 2017

  1. Update all package.json dependencies and switch to caret versioning.
  2. Switched to klaw, which used to be bundled with fs-extra but they removed it and directed users to use it directly.
  3. Clean up Webstorm Project, which was severely out of date.
  4. Fix coverage.

1. Update all package.json dependencies and switch to caret versioning.
2. Switched to `klaw`, which used to be bundled with fs-extra but they
removed it and directed users to use it directly.
2. Clean up Webstorm Project, which was severely out of date.
3. Fix coverage.
@mramato
Copy link
Contributor Author

mramato commented Apr 14, 2017

Travis is going to fail because it was enabled without having a .travis.xml set up in the root folder. This will be fixed in a separate PR (probably by someone else).

' -x "specs/**"' +
' -x "coverage/**"' +
' -x "gulpfile.js"' +
' -x "index.js"' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't skipping the bin directory lower the coverage stats?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't skipping the bin directory. And bin files can be programmatically unit tested just like the rest of the library so there's no reason to exclude them.

@shehzan10
Copy link
Member

Travis is going to fail because it was enabled without having a .travis.xml set up in the root folder. This will be fixed in a separate PR (probably by someone else).

I think we can pretty much copy the entire gltf-pipeline/.travis.yml.

@mramato
Copy link
Contributor Author

mramato commented Apr 14, 2017

I think we can pretty much copy the entire gltf-pipeline/.travis.yml.

It's not that simple. Since we have 3 separate npm packages in this repository, we need a top-level travis.yml that knows about each one and makes it easy to maintain and separate what each one does. It's not complicated, but definitely worth a separate PR to implement.

@mramato
Copy link
Contributor Author

mramato commented Apr 14, 2017

Moved klaw to dependencies

Thanks, totally missed that.

@lilleyse
Copy link
Contributor

Thanks, looks good. I'll open an issue for fixing travis.

@lilleyse lilleyse merged commit 891f504 into master Apr 14, 2017
@lilleyse lilleyse deleted the clean-up-project branch April 14, 2017 13:54
@lilleyse
Copy link
Contributor

Published to npm.

@mramato
Copy link
Contributor Author

mramato commented Apr 14, 2017

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants