-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up 3d-tiles-tools project and dependencies #70
Conversation
1. Update all package.json dependencies and switch to caret versioning. 2. Switched to `klaw`, which used to be bundled with fs-extra but they removed it and directed users to use it directly. 2. Clean up Webstorm Project, which was severely out of date. 3. Fix coverage.
Travis is going to fail because it was enabled without having a |
' -x "specs/**"' + | ||
' -x "coverage/**"' + | ||
' -x "gulpfile.js"' + | ||
' -x "index.js"' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't skipping the bin
directory lower the coverage stats?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aren't skipping the bin
directory. And bin files can be programmatically unit tested just like the rest of the library so there's no reason to exclude them.
I think we can pretty much copy the entire gltf-pipeline/.travis.yml. |
It's not that simple. Since we have 3 separate npm packages in this repository, we need a top-level travis.yml that knows about each one and makes it easy to maintain and separate what each one does. It's not complicated, but definitely worth a separate PR to implement. |
Thanks, totally missed that. |
Thanks, looks good. I'll open an issue for fixing travis. |
Published to npm. |
Awesome, thanks. |
klaw
, which used to be bundled withfs-extra
but they removed it and directed users to use it directly.