Batch Table Binary and other updates #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it was actually in pretty good shape. I made several edits. Please review. I did not look at the JSON schema. Let me know when it is ready. Make sure to validate the examples: https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/master/schema#usage |
This was referenced Sep 1, 2016
Closed
|
Cesium implementation: CesiumGS/cesium#4183 |
2 tasks
|
All your edits look fine to me. |
lilleyse
force-pushed
the
batch-table-binary
branch
from
b3b2462
to
9aabc6b
Compare
lilleyse
force-pushed
the
batch-table-binary
branch
from
9aabc6b
to
11155c6
Compare
|
Alright batch table schema is updated. I also made some changes to the feature table schema - @lasalvavida and @pjcozzi let me know if I changed something incorrectly. |
|
When running http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/pnts-updates/Specs/SpecRunner.html in Firefox, I get one related test failure: |
|
When running in Chrome - now with a clean cache - I did not get any 3D Tiles failures. |
|
Whoops, the above two comments are for CesiumGS/cesium#4183. |
| "patternProperties" : { | ||
| ".*" : { | ||
| "additionalProperties" : { | ||
| "anyOf": [ |
There was a problem hiding this comment.
Are you sure about this? The Feature Table properties could be anything: strings, numbers, arrays, objects with their schema, etc. It is up to the tile format to limit it.
There was a problem hiding this comment.
Good point, I just removed the additionalProperties section.
|
Just that one comment and this is ready to merge! Great work here. |
|
Posted the breaking b3dm changes to the forum: https://groups.google.com/forum/#!topic/cesium-dev/jY3wj0RVASM |
|
Why are we using strings for |
| @@ -40,6 +43,9 @@ | |||
| }, | |||
| "CONSTANT_RGBA" : { | |||
| "$ref" : "featureTable.schema.json#/definitions/globalPropertyCartesian3" | |||
| }, | |||
| "BATCH_LENGTH" : { | |||
There was a problem hiding this comment.
Is this property necessary? Can't we just assume that the batchIds provided are correct?
There was a problem hiding this comment.
It's needed because we expect multiple points to map to the same batchId. In the case of per-point properties, both BATCH_ID and BATCH_LENGTH can be omitted.
There was a problem hiding this comment.
Okay, should we add it to i3dm.featureTable as well? I think that can have a similar use case: where multiple instances are part of the same batch.
There was a problem hiding this comment.
Yeah that seems like a good idea to me.
Overall I think it helps with clarity, and 3D Tiles isn't tied to WebGL as much as glTF is (even though tiles contain glTF....). |
|
Is this ready to merge? |
|
Yeap, any tweaks can go into a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little rough at the moment, but ready for at least a first look. I still need to work on the batch table schema.