Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiles automatically when material changes #504

Open
1 of 2 tasks
lilleyse opened this issue Oct 20, 2023 · 1 comment · Fixed by #540
Open
1 of 2 tasks

Update tiles automatically when material changes #504

lilleyse opened this issue Oct 20, 2023 · 1 comment · Fixed by #540

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Oct 20, 2023

Tileset materials were added in #406 but there are some limitations. When you edit a tileset material the changes aren't propagated back to the tiles. There are two types of edits that we need to handle:

  • Changing individual material values - this could be implemented by watching for USD notifications and updating Fabric prims (a bit like Imagery layer alpha control #498).
  • Changes to the node graph - this is more involved and probably requires USD notification + tileset reload due to the fact that every tile's material is a copy of the material being edited.
@lilleyse
Copy link
Contributor Author

Alternatively, we could detect when a material is changed and prompt the user to reload the tileset rather than doing it automatically, kind of like the "Fetch USD changes" popup that appears when you edit a USD file. That might be less frustrating.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant