Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition when loading local tileset with custom materials #542

Open
lilleyse opened this issue Nov 9, 2023 · 0 comments
Open

Race condition when loading local tileset with custom materials #542

lilleyse opened this issue Nov 9, 2023 · 0 comments
Labels

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Nov 9, 2023

When loading a tileset with custom materials the materialHasCesiumNodes function doesn't return the correct result if the USD material hasn't been populated into Fabric yet. I only ever notice this when loading tilesets on disk. The end result is usually a blank material.

To fix this we should update materialHasCesiumNodes to look at the USD stage rather than the Fabric stage, if possible.

I can work around it by adding a 1 second wait to each HTTP request. Obviously this is a big hack, it just helps unblock other things I'm working on.

using namespace std::this_thread;
using namespace std::chrono_literals;
using std::chrono::system_clock;
sleep_for(1s);

Test data: feature-id-attribute-mdl.zip (make sure to update paths to the tileset.json in the .usda for your system)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants