Performance testing app #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
requested review from
weegeekps,
r-veenstra,
corybarr and
mattelser
as code owners
weegeekps
reviewed
Jun 21, 2023
apps/cesium.omniverse.dev.kit
Outdated
| @@ -17,6 +17,7 @@ app.useFabricSceneDelegate = true | |||
| app.usdrt.scene_delegate.enableProxyCubes = false | |||
| app.usdrt.scene_delegate.geometryStreaming.enabled = false | |||
| app.fastShutdown = true | |||
| app.viewport.grid.enabled = false | |||
There was a problem hiding this comment.
Could we not default this to off? It's easy enough to turn off manually and then it persists between sessions. I typically leave it on because it can be useful in some cases. By setting it off in this file, it turns it off every time for me.
There was a problem hiding this comment.
Sure, I removed this line
Comment on lines
+25
to
+26
| ION_ACCESS_TOKEN = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiIyZTA0MDlmYi01Y2RhLTQ0MjQtYjBlOS1kMmZhMzQ0OWRkNGYiLCJpZCI6MjU5LCJpYXQiOjE2ODU2MzExMTF9.y2CrqatkaHKHcj6NIDJ8ioll-tnOi-2CblnzI6iUays" # noqa: E501 | ||
| GOOGLE_3D_TILES_URL = "https://tile.googleapis.com/v1/3dtiles/root.json?key=AIzaSyC2PMYr_ZaMJT5DdZ8WJNYMwB0lDyvx5q8" |
There was a problem hiding this comment.
Thought for later. We ought to set up a way to use environment variables for this sort of thing, rather than hard coding it in the code. Easier to rotate values when we need to do so.
There was a problem hiding this comment.
Yeah, that would be better. I don't like hardcoding it either. I'll have a follow up PR for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
Follow up to #347 that fills out the performance testing application.
The UI is split into three categories:
Tracing Enabledoption is there to remind you if you have tracing enabled. I would have preferred using a read-only checkbox but didn't see an option inomni.ui.cesium.omniverse.TILESET_LOADEDevent to fire). The "Tour" scenario loads a single tileset and jumps between different locations. You can clickStopto stop the current scenario. This is useful for stopping tours early.Other notes:
cesium-omniverse-samplesand will need to be rotated monthly.Known issues:
computeLoadProgress.Future work:
And a video of it in action. I accidentally took this video in Debug mode so it's a bit slow.
perf-testing.mp4