Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc build warnings (UE 5.3) #1384

Merged
merged 8 commits into from
Apr 27, 2024
Merged

Fix misc build warnings (UE 5.3) #1384

merged 8 commits into from
Apr 27, 2024

Conversation

csciguy8
Copy link
Contributor

@csciguy8 csciguy8 commented Apr 2, 2024

Fixes these warnings

From CI (all UE versions)

D:\a\cesium-unreal\cesium-unreal\packages\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\CesiumTileExcluderAdapter.cpp(24): warning C4996: 'ACesiumGeoreference::GetGeoTransforms': Use transformation functions on ACesiumGeoreference and UCesiumWgs84Ellipsoid instead. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.`

From CI (UE 5.3 builds)

D:\a\cesium-unreal\cesium-unreal\packages\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\CesiumGltfPointsSceneProxy.cpp(54): warning C4996: 'FRenderResource::InitResource': InitResource now requires a command list. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
D:\a\cesium-unreal\cesium-unreal\packages\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\CesiumPointAttenuationVertexFactory.cpp(33): warning C4996: 'RHICreateBuffer': RHICreateBuffer is deprecated. Use FRHICommandListBase::CreateBuffer instead. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
D:\a\cesium-unreal\cesium-unreal\packages\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\CesiumPointAttenuationVertexFactory.cpp(40): warning C4996: 'RHILockBuffer': RHILockBuffer is deprecated. Use FRHICommandListBase::LockBuffer instead. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.
D:\a\cesium-unreal\cesium-unreal\packages\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\CesiumPointAttenuationVertexFactory.cpp(54): warning C4996: 'RHIUnlockBuffer': RHIUnlockBuffer is deprecated. Use FRHICommandListBase::UnlockBuffer instead. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.

Local windows debug UE 5.3 builds

\cesium-unreal\Source\CesiumRuntime\Private\CesiumFeaturesMetadataComponent.cpp(544): warning C4996: 'UMaterialExpression::GetInputs': Use GetInputsView() instead. Please update your code to the new API before upgrading to the next release, otherwise your project will no longer compile.

@csciguy8 csciguy8 changed the title Fix misc build warnings Fix misc UE 5.3 build warnings Apr 2, 2024
@csciguy8 csciguy8 changed the title Fix misc UE 5.3 build warnings Fix misc build warnings (UE 5.3) Apr 2, 2024
@j9liu j9liu self-requested a review April 26, 2024 16:44
@j9liu
Copy link
Contributor

j9liu commented Apr 26, 2024

Thanks @csciguy8 ! Will merge once CI passes.

@j9liu j9liu merged commit c818431 into main Apr 27, 2024
25 checks passed
@j9liu j9liu deleted the fix-warnings branch April 27, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants