-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22a5d63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love these changes except for the deliberate swapping of MIDDLE and RIGHT buttons. Not only STK and Insight3D, but also Google Earth uses right-mouse for zoom in addition to middle wheel spin for zoom, and GE uses middle-drag for rotation around the look point. In GE this means you can use the wheel for both rotating and zooming without moving your finger to other buttons, and it feels useful and natural to me. Using the wheel for both zooming and zooming feels redundant to me.
I believe @mramato argued for the swap on the idea that assigning a single purpose to both spin and drag of the middle button would be friendly, but after trying it out I strongly disagree. Existing Cesium users are already accustomed to right-mouse-zoom, as well as GE and STK users. Also, people without a mouse wheel (who still own a shift key) need zoom much more than they need rotate (given pan on the left). It's very clear to me now that the default behavior should be right-zoom, middle-drag-rotate, and wheel-spin-zoom.
22a5d63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a try and I agree with @emackey that it is probably more natural to swap middle and right buttons.