Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing for Cesium3DTileset.fromIonAssetId is incorrect #11623

Closed
angrycat9000 opened this issue Nov 13, 2023 · 0 comments · Fixed by #11626
Closed

Typing for Cesium3DTileset.fromIonAssetId is incorrect #11623

angrycat9000 opened this issue Nov 13, 2023 · 0 comments · Fixed by #11626

Comments

@angrycat9000
Copy link
Contributor

Cesium3DTileset.fromIonAssetId is marked as having a required options object. It is not actually required since it passes it to fromURL where the options object is not required.

fromIonAssetId

* @param {Cesium3DTileset.ConstructorOptions} options An object describing initialization options

fromUrl

* @param {Cesium3DTileset.ConstructorOptions} [options] An object describing initialization options

This causes a typescript error if fromIonAssetId is called without providing an options object

image

angrycat9000 added a commit that referenced this issue Nov 13, 2023
pupitetris pushed a commit to pupitetris/cesium-webxr that referenced this issue Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant