Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VoxelPrimitive.jitter option #11913

Closed
jjhembd opened this issue Mar 30, 2024 · 4 comments
Closed

Remove VoxelPrimitive.jitter option #11913

jjhembd opened this issue Mar 30, 2024 · 4 comments
Labels
category - voxels cleanup good first issue An opportunity for first time contributors JTC

Comments

@jjhembd
Copy link
Contributor

jjhembd commented Mar 30, 2024

The VoxelPrimitive.jitter option applies random shifts to the starting point for voxel ray-marching. This helped blur artifacts at the edges of voxels when using a constant step size.

After #11875, voxels use an optimum step size which fixes the artifacts. This makes the jitter unnecessary, and also effectively ignores the jitter after the first step.

This option should be removed. Since the voxel API is flagged experimental, we may not need a deprecation period.

@ggetz ggetz added good first issue An opportunity for first time contributors JTC labels Aug 19, 2024
@okrayum
Copy link
Contributor

okrayum commented Aug 21, 2024

Hello @ggetz, Jason from JTC here and I would like to work on this issue, please.

@ggetz
Copy link
Contributor

ggetz commented Aug 21, 2024

@okrayum Sounds good, thanks!

@okrayum
Copy link
Contributor

okrayum commented Aug 22, 2024

Hello @ggetz I made a PR #12146 for this issue.
cleanup: Remove VoxelPrimitive.jitter option (#11913)

ankittrehan2000 added a commit that referenced this issue Aug 26, 2024
cleanup: Remove VoxelPrimitive.jitter option (#11913)
@okrayum
Copy link
Contributor

okrayum commented Aug 29, 2024

I referenced 2 failing tests in the issues already known with those specs, however these are both different errors than what's listed in the existing issues

Chrome 128.0.0.0 (Windows 10): Executed 14263 of 14331 (2 FAILED) (skipped 68) (2 mins 35.598 secs / 2 mins 23.207 secs)
TOTAL: 2 FAILED, 14261 SUCCESS

1) picking in 3D
   Scene/GroundPolylinePrimitive
   Expected 'depth rectangle' to equal 'polyline on terrain'.
   at <Jasmine>
   at packages/engine/Specs/Scene/GroundPolylinePrimitiveSpec.js:821:27 <- Build/Specs/SpecList.js:178937:27
   at compare (Specs/addDefaultMatchers.js:387:13 <- Build/Specs/karma-main.js:355:13)
   at <Jasmine>

2) renders pnts with style and normals
   Scene/Model/Model3DTileContent pnts
   Expected 1 to be 0.
   at <Jasmine>
   at packages/engine/Specs/Scene/Model/Model3DTileContentSpec.js:919:29 <- Build/Specs/SpecList.js:253629:29
   at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
   at <Jasmine>
   Expected 1 to be 0.
   at <Jasmine>
   at packages/engine/Specs/Scene/Model/Model3DTileContentSpec.js:920:29 <- Build/Specs/SpecList.js:253630:29
   at compare (Specs/addDefaultMatchers.js:314:13 <- Build/Specs/karma-main.js:296:13)
   at <Jasmine>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - voxels cleanup good first issue An opportunity for first time contributors JTC
Projects
None yet
Development

No branches or pull requests

4 participants