Skip to content

Support depthFailMaterial for clamped polylines #8635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OmarShehata opened this issue Feb 26, 2020 · 0 comments
Open

Support depthFailMaterial for clamped polylines #8635

OmarShehata opened this issue Feb 26, 2020 · 0 comments

Comments

@OmarShehata
Copy link
Contributor

I couldn't find an issue on this, but it appears that depthFailMaterial is not support for polylines that are clamped to ground. This Sandcastle example works around this issue by not clamping the polyline to ground, and instead sampling the heights of the terrain:

https://sandcastle.cesium.com/index.html?src=Clamp%20to%20Terrain.html

(Click the "sample line positions" in the dropdown).

Here's a version of this that uses clampToGround: true. Notice depthFailMaterial has no effect and there is no warning or anything.

Is this just a matter of threading the depthFailAppearance down into StaticGroundPolylinePerMaterialBatch.js ? If there's a more fundamental reason why clamped polylines can't use depthFailMaterial we should issue a oneTimeWarning explaining that instead of silently failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant