Do not render constantly in requestRenderMode when dynamic geometries exist

[rropp5]

Description

Avoid requesting a new render from the Scene every time a Primitive is ready. With dynamic Primitives, they are destroyed and re-created each frame so this means they must be marked "ready" each frame. If they request a render each time they are ready, there is an infinite rendering loop that breaks requestRenderMode.

These changes simple modify the setReady() function on Primitives so it only sets the ready state and does not request a new frame.

Issue number and link

This resolves the problems reported under #6631.

Testing plan

I created several sandcastles on the linked issue (#6631) to address Primitives and GroundPrimitives. I have also tested to confirm non-dynamic Primitives render as expected when requestRenderMode is enabled and when it is disabled.

Updated original Sandcastle from #6631 : Expected behavior is that the ellipse does not begin to move when play is pressed

Case 1: animation is paused, Infinity maximumRenderTimeChange

Ground Primitive : Expected behavior is that the ellipse only changes size when the "Request Render" button is clicked

Primitive : Expected behavior is that the ellipse only changes size when the "Request Render" button is clicked

Case 2: animation is active, 2 second maximumRenderTimeChange

Ground Primitive : Expected behavior is that the ellipse changes size every 2 seconds

Primitive : Expected behavior is that the ellipse changes size every 2 seconds

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change
• I have added or updated unit tests to ensure consistent code coverage
• I have update the inline documentation, and included code examples where relevant
• I have performed a self-review of my code

[ggetz]

Thanks for the suggestion @rropp5! I can confirm we have a CLA on file for you.

[ggetz]

@rropp5 I think this is a valid way to address the issue. I've tested the example from #10517 where this code was originally added, and request render mode continue to function as expected.

Would you mind syncing up with main and updating CHANGES.md such that your fix is under the next release, 1.116?

[rropp5]

@ggetz No problem! The branches should be synced now and I added 1.116 to the CHANGES.md so I believe we're good to go.

[ggetz]

Thanks @rropp5!