Camera

[bagnell]

Removed Camera2DController, CameraCentralBodyController, CameraColumbusViewController, CameraFlightController, CameraFreeLookController, CameraSpindleController, and CameraControllerCollection. Common ways to modify the camera are through the CameraController object of the Camera and will work in all scene modes. The default camera mouse handler is the CameraMouseController object on the Scene. The CameraMouseController translates mouse input to camera movement through the camera's controller.

[kring]

In the Simple CZML Demo Sandcastle example, clicking the Vehicle button throws this error:
Uncaught TypeError: Object [object Object] has no method 'getCameraMouseController' (on line 118 of http://localhost:8080/Source/DynamicScene/DynamicObjectView.js)

[kring]

Also the "Two Canvases" example throws this error on load:
Uncaught TypeError: Object [object Object] has no method 'setSunPosition' (on line 46)

[kring]

Last one: picking seems to be messed up in the Volumes example. Mousing over the blue-white volume usually highlights the red one instead.

[bagnell]

@kring Thanks. The first two are fixed. The third is a problem in master as well.

[emackey]

Volume picking bug is #349.

[mramato]

EventHandler was renamed, but EventModifier was not. These types seem like they should be consistent with each other.

[mramato]

This might not be a big deal (and could be reserved for future cleanup) but we can probably cache the result of getScreenSpaceCameraController() instead of calling the function every time, right? Same for other calls to this function throughout this file.

[kring]

This might not be a big deal (and could be reserved for future cleanup) but we can probably cache the result of getScreenSpaceCameraController() instead of calling the function every time, right? Same for other calls to this function throughout this file.

DynamicObjectView apparently doesn't require that the scene be provided to the constructor, as long as it is set before update is called. So Dan's change as a result of this comment broke two tests in DynamicObjectViewSpec that were not providing a scene. I was just going to fix it myself, but it's not obvious to me what should change. If scene is optional at construction time and then the user can set it later, then we can't cache the result of screenSpaceCameraController in the constructor or maybe even at all.

[bagnell]

@mramato I made the changes you suggested. Anything else that can be improved?

[mramato]

Looks good, merging.

[pjcozzi]

@emackey what touch events does this merge add? Can you please add them to CHANGES.md in master? (yes, I said master; crazy, I know).

[emackey]

Can you please add them to CHANGES.md in master?

Done.