glTF 1.0.1 uint32 indices #4249
Conversation
|
CC @lexaknyazev - glTF 1.0.1 |
| @@ -1533,6 +1533,17 @@ define([ | |||
|
|
|||
| /////////////////////////////////////////////////////////////////////////// | |||
|
|
|||
| function loadGLExtensions(model, context) { | |||
There was a problem hiding this comment.
There's no need for this and this level of the Cesium stack should avoid making direct GL calls, see http://cesiumjs.org/2015/05/15/Graphics-Tech-in-Cesium-Architecture/
The uint32 extension is initialized here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Renderer/Context.js#L277
Model should check Context.elementIndexUint and throw a RuntimeError if the model wants to use the uint32 extension, but the system does not support it.
lasalvavida
force-pushed
the
gltf-1.0.1-uint32-indices
branch
from
6a25c7e
to
246a848
Compare
|
Updated |
|
@pjcozzi Can you look at this when you get a chance? |
1 similar comment
|
@pjcozzi Can you look at this when you get a chance? |
| @@ -3115,6 +3115,7 @@ define([ | |||
| var context = frameState.context; | |||
| var scene3DOnly = frameState.scene3DOnly; | |||
|
|
|||
| checkSupportedGlExtensions(model, context); | |||
There was a problem hiding this comment.
Can we move this call to be next to checkSupportedExtensions in update?
| @@ -3475,6 +3476,21 @@ define([ | |||
| } | |||
| } | |||
|
|
|||
| function checkSupportedGlExtensions(model, context) { | |||
There was a problem hiding this comment.
Can you document this exception in the update function reference doc? Also add the exception from checkSupportedExtensions which is missing.
| if (extension !== 'OES_element_index_uint') { | ||
| throw new RuntimeError('Unsupported WebGL Extension: ' + extension); | ||
| } else if (!context.elementIndexUint) { | ||
| throw new RuntimeError('OES_element_index_uint WebGL extension is not enabled.'); |
There was a problem hiding this comment.
Perhaps 'The OES_element_index_uint WebGL extension is required for this glTF model, but it is not supported by this system'
| context._elementIndexUint = false; | ||
| return loadModel(boxUint32Indices).otherwise(function(e) { | ||
| expect(e).toBeDefined(); | ||
| context._elementIndexUint = true; |
There was a problem hiding this comment.
Save and restore the original value; it could be false on some systems in theory.
|
Just those comments. Sorry for the delayed review. |
…to gltf-1.0.1-uint32-indices
…/cesium into gltf-1.0.1-uint32-indices
Part of #4009.
Merge #4248 first.