Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Tiles - Use tileset version when querying external uris #5077

Merged
merged 4 commits into from
Mar 7, 2017

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Mar 6, 2017

For #3241

I combed through the 3d-tiles code for cases of requesting external uris. In some areas the query and fragments of the tileset url would not be used, in particular this means the tileset version would be missing.

I'm about to add some tests as well.

@lilleyse
Copy link
Contributor Author

lilleyse commented Mar 6, 2017

Fixes CesiumGS/3d-tiles#187

@lilleyse
Copy link
Contributor Author

lilleyse commented Mar 6, 2017

Ready now. The tests check a variety of cases:

  • i3dm with an embedded gltf that references external images/shaders
  • i3dm with external gltf that references external images/shaders
  • b3dm with embedded gltf that references external images/shaders
  • Nested tilesets to ensure the query parameters are preserved for external tilesets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants