Fix depth fail material in Edge #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjcozzi
reviewed
May 24, 2017
Source/Scene/Primitive.js
Outdated
| @@ -994,15 +994,11 @@ define([ | |||
| function depthClampVS(vertexShaderSource) { | |||
| var modifiedVS = ShaderSource.replaceMain(vertexShaderSource, 'czm_non_depth_clamp_main'); | |||
| modifiedVS += | |||
| '#ifdef GL_EXT_frag_depth\n' + | |||
There was a problem hiding this comment.
As an explicit optimization, we usually put the #ifdef everywhere and do not rely, for example, on the GLSL compiler to optimize out unused code.
Perhaps add a comment here that this is used for frag depth, but it is not in an #ifdef to workaround an Edge bug.
Also submit an Edge bug please.
|
Here is a link to the Edge issue: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12120362/ |
|
@pjcozzi This is ready for another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always include frag depth varying even when not supported. Fixes #5357.