Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KML ground overlay distortion bug #5915

Merged
merged 4 commits into from
Oct 18, 2017
Merged

Fix KML ground overlay distortion bug #5915

merged 4 commits into from
Oct 18, 2017

Conversation

juburr
Copy link
Contributor

@juburr juburr commented Oct 18, 2017

Fixes #5914

@cesium-concierge
Copy link

Welcome to the Cesium community @jburr-nc!

Can you please send in a Contributor License Agreement (CLA) so that we can review and merge this pull request?

I am a bot who helps you make Cesium awesome! Thanks again.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 18, 2017

Awesome! Thanks for fixing this @jburr-nc!
Could you add a unit test? I imagine it will be similar to this one, just check that stRotation is also correct: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Specs/DataSources/KmlDataSourceSpec.js#L794-L812

As soon as we receive your CLA we'll be able to merge this.

@juburr
Copy link
Contributor Author

juburr commented Oct 18, 2017

@hpinkos The CLA for Novetta should be submitted. I added an additional check to the rotation test that was already there. Would you prefer a brand new test instead?

@hpinkos
Copy link
Contributor

hpinkos commented Oct 18, 2017

Thanks, I can confirm that we have your CLA. And that test looks fine to me!

Thanks again @jburr-nc!

@hpinkos hpinkos merged commit 404a1e9 into CesiumGS:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants