Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix point cloud crash in IE #6051

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Fix point cloud crash in IE #6051

merged 3 commits into from
Dec 14, 2017

Conversation

lilleyse
Copy link
Contributor

This fixes a crash in IE where the tile_translucentCommand uniform is discovered by gl.getActiveUniform but is not included in the uniform map. The fix is to to not declare tile_translucentCommand if handleTranslucent is false, which is the case for point clouds.

Chrome and Firefox must be smarter about realizing the uniform was not actually being used, so this bug did not surface on those browsers.

@cesium-concierge
Copy link

Signed CLA is on file.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Dec 14, 2017

Looks great, thanks @lilleyse!

@hpinkos hpinkos merged commit 0001e25 into master Dec 14, 2017
@hpinkos hpinkos deleted the ie-point-cloud-fix branch December 14, 2017 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants