Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when morphing from 2D to 3D is cancelled. #6949

Merged
merged 2 commits into from
Aug 23, 2018
Merged

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Aug 22, 2018

Fixes #6929.

A better way to reproduce this consistently is to:

  1. Switch to 2D
  2. Zoom in a bit.
  3. Switch to 3D.
  4. Cancel the morph by clicking the canvas.

@cesium-concierge
Copy link

Thanks for the pull request @bagnell!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Aug 23, 2018

Looks good, thanks @bagnell!

@hpinkos hpinkos merged commit c00cec1 into master Aug 23, 2018
@hpinkos hpinkos deleted the fix-morph-crash branch August 23, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants