-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
work-around dimensionless SVG in Firefox #9191
work-around dimensionless SVG in Firefox #9191
Conversation
Thanks for the pull request @nmschulte!
Reviewers, don't forget to make sure that:
|
185320b
to
a8bdf0f
Compare
Added unit tests. Chromium was using a default dimension of 300x150 if there is no |
a8bdf0f
to
5ddca05
Compare
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
4 similar comments
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with |
3 similar comments
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with |
Thanks again for your contribution @nmschulte! No one has commented on this pull request in 90 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 90 days. If you'd like me to stop, just comment with |
Hi @nmschulte, sorry for the delay in getting this reviewed. Was the work around in #9188 (comment) enough for your use case? If not and you have the time to update this PR, let us know. |
@ggetz I had developed a work-around for my use-case before ever distilling this information for the team and community to digest here. There are still open questions in my response to the supposed work-around you reference; I don't think it is a general solution in line with the API CesiumJS is putting forward, no. Combining my last remarks with my first, there is a solution to be had, the team just needs to review the situation and make a decision. "Not a bug" would surely be a disappointing resolution in my opinion. |
I do see this is related to an open issue in Firefox-- https://bugzilla.mozilla.org/show_bug.cgi?id=700533-- And they seem hesitant to call this a straightforward defect, although they do admit that the behavior is different from Chrome and Edge. From a consistency standpoint at least, I think these changes here makes sense. If you don't mind updating your branch with the latest |
c635ed2
to
bd314ee
Compare
bd314ee
to
c03ea38
Compare
Thanks @nmschulte ! |
Attempts to resolve #9188.