Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArcGISTiledElevationTerrainProvider TypeScript definition #9522

Merged
merged 1 commit into from
May 3, 2021

Conversation

mramato
Copy link
Contributor

@mramato mramato commented May 2, 2021

#9465 (comment)

There was no new line after the WebGLConstants enum definition in the TypeScript definition file:

...
    MAX_TEXTURE_MAX_ANISOTROPY_EXT = 34047
}/**
 * A {@link TerrainProvider} that produces terrain geometry by tessellating height maps
...

This caused ArcGISTiledElevationTerrainProvider to not be completely picked up by the TypeScript compiler. There's special handling from WebGLConstants to hoist it to the top of the file, so we just needed to insert two new lines in the special handling code to fix the problem:

...
    MAX_TEXTURE_MAX_ANISOTROPY_EXT = 34047
}

/**
 * A {@link TerrainProvider} that produces terrain geometry by tessellating height maps
...

There was no new line after the WebGLConstants enum definition in the
TypeScript definition file:

```
    MAX_TEXTURE_MAX_ANISOTROPY_EXT = 34047
}/**
 * A {@link TerrainProvider} that produces terrain geometry by tessellating height maps

```

This caused `ArcGISTiledElevationTerrainProvider` to not be completely
picked up by the TypeScript compiler. There's special handling from
WebGLConstants to hoist it to the top of the file, so we just needed to
insert two new lines in the special handling code to fix the problem:

```
    MAX_TEXTURE_MAX_ANISOTROPY_EXT = 34047
}

/**
 * A {@link TerrainProvider} that produces terrain geometry by tessellating height maps

```
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor Author

mramato commented May 2, 2021

To test this, just run build-ts and compare it to master and you'll see that the new line is inserted as described above.

@mramato
Copy link
Contributor Author

mramato commented May 3, 2021

Self merging this so that I can start the release.

@mramato mramato merged commit abbf4a5 into master May 3, 2021
@mramato mramato deleted the tsd-fix branch May 3, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants